Skip to content

chore: Fixed test #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 31, 2024
Merged

chore: Fixed test #627

merged 2 commits into from
Dec 31, 2024

Conversation

baseballyama
Copy link
Member

@baseballyama baseballyama commented Dec 31, 2024

I think the reason of this failure is typescript-eslint/typescript-eslint#10454

+ expected - actual

     "ruleId": "@typescript-eslint/no-unnecessary-condition",
     "code": "foo == null",
     "line": 4,
     "column": 15,
-    "message": "Unnecessary conditional, comparison is always true, since `null == null` is true."
+    "message": "Unnecessary conditional, comparison is always true. Both sides of the comparison always have a literal type."
   },
   {
     "ruleId": "@typescript-eslint/no-unnecessary-condition",
     "code": "bar == null",
     "line": 8,
     "column": 13,
-    "message": "Unnecessary conditional, comparison is always true, since `null == null` is true."
+    "message": "Unnecessary conditional, comparison is always true. Both sides of the comparison always have a literal type."
   }
 ]

Copy link

changeset-bot bot commented Dec 31, 2024

⚠️ No Changeset found

Latest commit: b13e584

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Dec 31, 2024

Open in Stackblitz

npm i https://pkg.pr.new/svelte-eslint-parser@627

commit: b13e584

@baseballyama baseballyama merged commit ba33301 into main Dec 31, 2024
13 checks passed
@baseballyama baseballyama deleted the chore/fix-test branch December 31, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant